fix: bind hover and pressed states to background#1634
Open
MyLeeJiEun wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBinds the app item background delegate’s hover and press visual states to existing input handlers so taskbar items correctly reset their selected state after dismissing a long-press popup. Sequence diagram for binding hover and pressed states to background delegatesequenceDiagram
actor User
participant hoverHandler
participant mouseArea
participant backgroundDelegate
participant D_ColorSelector as D_ColorSelector
User->>hoverHandler: hovered
hoverHandler-->>backgroundDelegate: hovered
backgroundDelegate-->>D_ColorSelector: D.ColorSelector.hovered
User->>mouseArea: press
mouseArea-->>backgroundDelegate: pressed
backgroundDelegate-->>D_ColorSelector: D.ColorSelector.pressed
User->>User: [popup dismissed by clicking desktop]
mouseArea-->>backgroundDelegate: pressed false
backgroundDelegate-->>D_ColorSelector: D.ColorSelector.pressed false
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider verifying that
hoverHandlerandmouseAreacover the same visual region as the app item background; if their geometries differ, the newD.ColorSelector.hovered/pressedbindings could desynchronize background feedback from the actual interactive area. - To improve readability, you might group the new
D.ColorSelector.hoveredandD.ColorSelector.pressedbindings with any other state-related properties (e.g.isActive,displayMode) or add a short comment explaining that these are wired to the background’s visual states.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider verifying that `hoverHandler` and `mouseArea` cover the same visual region as the app item background; if their geometries differ, the new `D.ColorSelector.hovered/pressed` bindings could desynchronize background feedback from the actual interactive area.
- To improve readability, you might group the new `D.ColorSelector.hovered` and `D.ColorSelector.pressed` bindings with any other state-related properties (e.g. `isActive`, `displayMode`) or add a short comment explaining that these are wired to the background’s visual states.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mhduiy
approved these changes
Jun 12, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
1. Add D.ColorSelector.hovered and D.ColorSelector.pressed properties to the app item background delegate 2. Fix taskbar app retaining selected state after long-press popup is dismissed by clicking desktop blank area Log: fix taskbar app keeping selected state after dismissing long-press popup fix: 绑定悬停和按下状态到背景 1. 为应用项背景委托添加 D.ColorSelector.hovered 和 D.ColorSelector.pressed 属性 2. 修复单指长按任务栏应用弹出面板后，点击桌面空白处 任务栏应用依然有选中状态的问题 Log: 修复长按弹出面板关闭后任务栏应用残留选中状态的问题 PMS: BUG-364531
MyLeeJiEun
force-pushed
the
fork-from-master-0612-fix-issue-364531
branch
from
0d84fe5 to
edf9c9f
Compare
|
This pr cannot be merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: fix taskbar app keeping selected state after dismissing long-press popup
fix: 绑定悬停和按下状态到背景
Log: 修复长按弹出面板关闭后任务栏应用残留选中状态的问题
PMS: BUG-364531
Summary by Sourcery
Bug Fixes: